Re: [v4l-utils PATCH 4/4] v4l2-ctl: Add support for META_OUTPUT buffer type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/22/19 10:47, Sakari Ailus wrote:
> Hi Hans,
> 
> On Tue, Jan 22, 2019 at 09:19:42AM +0100, Hans Verkuil wrote:
>> Hi Sakari,
>>
>> Can you check if this patch is needed at all? The latest v4l2-ctl should work
>> for both meta capture and output, i.e. all meta options (v4l2-ctl --help-meta)
>> just look up the buffer type of the video device and use that to list/set/get/try
>> the formats.
> 
> That'd be one option. I guess we don't have that elsewhere, do we? In
> practice it could work, but it'd prevent having the two queue types in the
> same video node. It seems an improbable combination though.
> 
> I'd prefer keeping the options separate to maintain v4l2-ctl's ability to
> access all aspects of the API, even if unlikely.

Well, you can add -out options for consistency, but the code remains the
same :-)

> But the help option should probably be unified, like it is for SDR.
> 

Definitely.

Regards,

	Hans



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux