On Mon, Jan 21, 2019 at 11:11 AM Jiri Kosina <jikos@xxxxxxxxxx> wrote: > > On Fri, 18 Jan 2019, Dmitry Torokhov wrote: > > > It is hard to say what KEY_SCREEN and KEY_ZOOM mean, but historically DVB > > folks have used them to indicate switch to full screen mode. Later, they > > converged on using KEY_ZOOM to switch into full screen mode and KEY)SCREEN > > to control aspect ratio (see Documentation/media/uapi/rc/rc-tables.rst). > > > > Let's commit to these uses, and define: > > > > - KEY_FULL_SCREEN (and make KEY_ZOOM its alias) > > - KEY_ASPECT_RATIO (and make KEY_SCREEN its alias) > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > --- > > > > Please let me know how we want merge this. Some of patches can be applied > > independently and I tried marking them as such, but some require new key > > names from input.h > > Acked-by: Jiri Kosina <jkosina@xxxxxxx> Acked-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> > > for the HID changes, and feel free to take it through your tree as a > whole, I don't expect any major conflicts rising up from this. Works for me too. My tests showed no issues, so that's OK from me. Cheers, Benjamin > > Thanks, > > -- > Jiri Kosina > SUSE Labs >
