On Fri, 2019-01-18 at 12:18 +0100, Philipp Zabel wrote:
> Hi Hans,
>
> On Fri, 2019-01-18 at 10:30 +0100, Hans Verkuil wrote:
> > On 1/17/19 4:50 PM, Philipp Zabel wrote:
>
> [...]
> > > +
> > > +static const struct video_device ipu_csc_scaler_videodev_template = {
> > > + .name = "ipu0_ic_pp mem2mem",
> >
> > I would expect to see something like 'imx-media-csc-scaler' as the name.
> > Wouldn't that be more descriptive?
>
> Yes, thank you. I'll change this as well.
Actually, this is overwritten a few lines later anyway:
snprintf(vfd->name, sizeof(vfd->name), "ipu_ic_pp mem2mem");
Not that it makes a difference. But I noticed that I chose this name for
something close to consistency with the other IPU devices:
$ cat /sys/class/video4linux/video*/name
ipu_ic_pp mem2mem
coda-encoder
coda-decoder
ipu1_ic_prpenc capture
ipu1_ic_prpvf capture
ipu2_ic_prpenc capture
ipu2_ic_prpvf capture
ipu1_csi0 capture
ipu1_csi1 capture
ipu2_csi0 capture
ipu2_csi1 capture
They all start with the IPU / subdevice (/ IC task) prefix.
Maybe "ipu_ic_pp csc/scaler" would be more appropriate?
regards
Philipp
