On Tue, Jan 12, 2010 at 3:28 PM, Jiri Slaby <jirislaby@xxxxxxxxx> wrote: > On 01/12/2010 12:48 AM, Andy Walls wrote: >> On Sun, 2010-01-10 at 09:56 +0100, Jiri Slaby wrote: >>> Stanse found a potential null dereference in cx18_dvb_start_feed >>> and cx18_dvb_stop_feed. There is a check for stream being NULL, >>> but it is dereferenced earlier. Move the dereference after the >>> check. >>> >>> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> >> >> Reviewed-by: Andy Walls <awalls@xxxxxxxxx> >> Acked-by: Andy Walls <awalls@xxxxxxxxx> > > You definitely know the code better, have you checked that it can happen > at all? I mean may demux->priv be NULL? It is highly unlikely that demux->priv becoming NULL. The only time that could happen would be when there is a dvb register failed. But in which case, it wouldn't reach the stage where you want to start/stop a stream. Regards, Manu -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
