Hi Laurent,
On Thu, Jan 10, 2019 at 9:09 PM Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>
> Implement miscellaneous changes that have been proposed in review
> comments but not captured, rephrase and clarify parts of the
> documentation, and mark shell code blocks appropriately.
>
> Major changes are still required, included rewriting the examples
> without the v4l2n tool, and documenting the internal blocks of the ImgU.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> Documentation/media/v4l-drivers/ipu3.rst | 201 +++++++++++------------
> 1 file changed, 94 insertions(+), 107 deletions(-)
>
Thanks for the patch! Some comments inline not directly related to it
and more a material for follow up patches.
Feel free to add my Reviewed-by.
[snip]
> -With ImgU, once the input video node ("ipu3-imgu 0/1":0, in
> -<entity>:<pad-number> format) is queued with buffer (in packed raw Bayer
> -format), ImgU starts processing the buffer and produces the video output in YUV
> -format and statistics output on respective output nodes. The driver is expected
> -to have buffers ready for all of parameter, output and statistics nodes, when
> -input video node is queued with buffer.
> +With ImgU, a buffer is queued on the input video node ("ipu3-imgu 0/1":0, in
> +<entity>:<pad-number> format), the ImgU starts processing the buffer and
> +produces the video output in YUV format and statistics output on respective
> +output nodes. The driver is expected to have buffers ready for all of parameter,
I think it's the driver that actually expects to have buffers ready
for all of the other nodes, not the other way around.
> +output and statistics nodes, when a buffer is queued on the input video node.
AFAICT the behavior at input buffer queue time is that if there is no
buffer queued for the parameters, last parameters are kept and if
there is no buffer queued for any of the CAPTURE buffers, an internal
dummy buffer is used and so effectively the related output of the ISP
gets ignored.
>
> At a minimum, all of input, main output, 3A statistics and viewfinder
> video nodes should be enabled for IPU3 to start image processing.
Hmm, wasn't the viewfinder optional?
Best regards,
Tomasz
