Re: [PATCH v2 14/30] media: entity: Add debug information in graph walk route check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Niklas,

Thank you for the patch.

On Fri, Nov 02, 2018 at 12:31:28AM +0100, Niklas Söderlund wrote:
> From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> ---
>  drivers/media/media-entity.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
> index a5bb257d5a68f755..42977634d7102852 100644
> --- a/drivers/media/media-entity.c
> +++ b/drivers/media/media-entity.c
> @@ -360,6 +360,9 @@ static void media_graph_walk_iter(struct media_graph *graph)
>  	 */
>  	if (!media_entity_has_route(pad->entity, pad->index, local->index)) {
>  		link_top(graph) = link_top(graph)->next;
> +		dev_dbg(pad->graph_obj.mdev->dev,
> +			"walk: skipping \"%s\":%u -> %u (no route)\n",
> +			pad->entity->name, pad->index, local->index);

Maybe "%s: skipping...", __func__, ?

Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

>  		return;
>  	}
>  

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux