On Tue, 2019-01-15 at 12:40 +0200, Sakari Ailus wrote: > On Tue, Jan 15, 2019 at 09:54:43AM +0100, Lubomir Rintel wrote: > > Hi, > > > > here are the ov7670 patches originally from the "media: make Marvell camera > > work on DT-based OLPC XO-1.75" updated to apply cleanly on top of > > <git://linuxtv.org/sailus/media_tree.git> master as requested. > > > > I've also added "ov7670: Remove useless use of a ret variable" with my Ack > > slapped on it. > > Hi Lubomir, > > It seems the end result compiles but the intermedia patches do not. Could > you resend, please? I'll replace the patches in my tree with a new version > then... Seems like the order got messed up. It should be sufficient to reorder the patches like this: pick f42ae764598a ov7670: Remove useless use of a ret variable pick 5be2efe0e5bb media: ov7670: split register setting from set_fmt() logic pick 38eed963866e media: ov7670: split register setting from set_framerate() logic pick 97be3c31de46 media: ov7670: hook s_power onto v4l2 core pick 56c292d92642 media: ov7670: control clock along with power (With "git rebase -i 87680151c22eee5b3bb6361fb8d18d765a9d8aff") > > Thanks. Cheers, Lubo