On 1/14/19 6:04 PM, Helen Koike wrote: > Hi Hans, > > Thanks for the patch. > > On 1/14/19 12:58 PM, Hans Verkuil wrote: >> Add VB2_USERPTR to the vimc capture device. >> >> Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> >> --- >> diff --git a/drivers/media/platform/vimc/vimc-capture.c b/drivers/media/platform/vimc/vimc-capture.c >> index 3f7e9ed56633..35c730f484a7 100644 >> --- a/drivers/media/platform/vimc/vimc-capture.c >> +++ b/drivers/media/platform/vimc/vimc-capture.c >> @@ -431,7 +431,7 @@ static int vimc_cap_comp_bind(struct device *comp, struct device *master, >> /* Initialize the vb2 queue */ >> q = &vcap->queue; >> q->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; >> - q->io_modes = VB2_MMAP | VB2_DMABUF; >> + q->io_modes = VB2_MMAP | VB2_DMABUF | VB2_USERPTR; >> q->drv_priv = vcap; >> q->buf_struct_size = sizeof(struct vimc_cap_buffer); >> q->ops = &vimc_cap_qops; >> > > I remember at the time I was having some issues regarding userptr, I > just want to make a few tests first. Make sure you update to the latest v4l-utils first: there was a v4l2-compliance bug that caused an incorrect FAIL for vimc. Regards, Hans
