On Mon, Jan 14, 2019 at 4:00 AM Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx> wrote: > > Hi James, > > Em Mon, 14 Jan 2019 07:38:25 +0800 > james.hilliard1@xxxxxxxxx escreveu: > > > From: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> > > > > Please add description to the patches. It helps reviewing them, and, > if we need to revert it for whatever reason in the future, the git log > will help to take into account the rationale about why the change was > needed in the first place. > > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> > > Signed-off-by: James Hilliard <james.hilliard1@xxxxxxxxx> > > --- > > configure.ac | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure.ac b/configure.ac > > index a03d10e..6476a20 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -5,7 +5,7 @@ m4_ifndef([AC_LANG_DEFINES_PROVIDED], > > [m4_define([AC_LANG_DEFINES_PROVIDED])]) > > AC_CONFIG_AUX_DIR(config) > > AC_CONFIG_MACRO_DIR(config) > > -AM_INIT_AUTOMAKE([1.13 -Werror foreign subdir-objects std-options dist-bzip2]) > > +AM_INIT_AUTOMAKE([1.13 foreign subdir-objects std-options dist-bzip2]) > > m4_pattern_allow([AM_PROG_AR]) > > AC_CONFIG_HEADERS([include/config.h]) > > AC_CONFIG_SRCDIR(zbar/scanner.c) > > I applied patches 2 to 5 of this series, but I would prefer to keep the > -Werror here, as it helps to identify and fix potential issues. > > Here (Fedora 29), everything builds fine, but I haven't test on other > distros that could have newer packages. > > Why is this patch needed? It was part of buildroot's zbar patches, not sure if it's needed though anymore. > > Regards, > Mauro > > Thanks, > Mauro
