Hi David,
On Mon, Jan 07, 2019 at 10:30:55PM +0000, David Binderman wrote:
> Hello there,
>
> drivers/staging/media/ipu3/ipu3-css.c:1831:30: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
>
> Source code is
> css->pipes[pipe].bindex =
> ipu3_css_find_binary(css, pipe, q, r);
> if (css->pipes[pipe].bindex < 0) {
> dev_err(css->dev, "failed to find suitable binary\n");
> return -EINVAL;
> }
>
> Suggest sanity check return value from function first, then if it is ok,
> assign it to an unsigned variable.
Thanks for reporting this. There have been a few patches to address it so
far, the one going in is here:
<URL:https://patchwork.linuxtv.org/patch/53633/>
--
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx
