On 01/04/2019 11:29 AM, Dafna Hirschfeld wrote: > Add support for the selection api for the crop and compose targets. > The driver rounds up the coded width and height such that > all planes dimensions are multiple of 8. > > Signed-off-by: Dafna Hirschfeld <dafna3@xxxxxxxxx> > --- > This patch temporarily dysfunction vicoded since it does not vicoded -> vicodec > allow setting the visible resolution for the decoder. Actually, this patch doesn't break anything in vicodec. Currently vicodec doesn't support padding at all, so there is no loss of functionality. > Next patch will fix it by adding resolution-change event > after reading the first compressed frame header. > > Main changes from v5: > - Replace 'coded_width*step' with 'stride' in order to get the offset of next row > - allow setting only CROP selection for the encoder. > > drivers/media/platform/vicodec/codec-fwht.c | 80 +++-- > drivers/media/platform/vicodec/codec-fwht.h | 17 +- > .../media/platform/vicodec/codec-v4l2-fwht.c | 290 ++++++++++++------ > .../media/platform/vicodec/codec-v4l2-fwht.h | 7 +- > drivers/media/platform/vicodec/vicodec-core.c | 150 +++++++-- > 5 files changed, 382 insertions(+), 162 deletions(-) > Other than the commit message which needs a bit more work, this patch looks good! So the next patch will deal with the decoder, correctly detecting the resolution from the header. Once that's ready I should be able to merge everything and you can start work on the stateless codec. BTW, the next time you post your changes, post all the pending changes, so include "[PATCH] media: vicodec: Add num_planes field to v4l2_fwht_pixfmt_info". It's easier to keep track for me if I see all the changes made on top of the current master branch. Regards, Hans
