RE: [PATCH 1/1] media: staging/intel-ipu3: Fix Kconfig for unmet direct dependencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Sakari,

> -----Original Message-----
> From: Sakari Ailus [mailto:sakari.ailus@xxxxxxxxxxxxxxx]
> Sent: Wednesday, January 2, 2019 2:11 PM
> To: Zhi, Yong <yong.zhi@xxxxxxxxx>
> Cc: linux-media@xxxxxxxxxxxxxxx; tfiga@xxxxxxxxxxxx; Mani, Rajmohan
> <rajmohan.mani@xxxxxxxxx>; hans.verkuil@xxxxxxxxx;
> mchehab@xxxxxxxxxx; laurent.pinchart@xxxxxxxxxxxxxxxx; Cao, Bingbu
> <bingbu.cao@xxxxxxxxx>; Qiu, Tian Shu <tian.shu.qiu@xxxxxxxxx>
> Subject: Re: [PATCH 1/1] media: staging/intel-ipu3: Fix Kconfig for unmet
> direct dependencies
> 
> Hi Yong,
> 
> On Mon, Dec 31, 2018 at 11:46:43AM -0600, Yong Zhi wrote:
> > Fix link error for specific .config reported by lkp robot:
> >
> > drivers/staging/media/ipu3/ipu3-dmamap.o: In function
> `ipu3_dmamap_alloc':
> > drivers/staging/media/ipu3/ipu3-dmamap.c:111: undefined reference to
> `alloc_iova'
> >
> > Signed-off-by: Yong Zhi <yong.zhi@xxxxxxxxx>
> > ---
> > Happy New Year!!
> >
> >  drivers/staging/media/ipu3/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/ipu3/Kconfig
> > b/drivers/staging/media/ipu3/Kconfig
> > index 75cd889f18f7..c486cbbe859a 100644
> > --- a/drivers/staging/media/ipu3/Kconfig
> > +++ b/drivers/staging/media/ipu3/Kconfig
> > @@ -3,7 +3,7 @@ config VIDEO_IPU3_IMGU
> >  	depends on PCI && VIDEO_V4L2
> >  	depends on MEDIA_CONTROLLER && VIDEO_V4L2_SUBDEV_API
> >  	depends on X86
> > -	select IOMMU_IOVA
> > +	select IOMMU_IOVA if IOMMU_SUPPORT
> 
> I don't think this really addresses the issue: the IOVA library is needed in any
> case. I'll submit a patch...
> 

Sure, thanks!!

> >  	select VIDEOBUF2_DMA_SG
> >  	---help---
> >  	  This is the Video4Linux2 driver for Intel IPU3 image processing
> > unit,
> > --
> > 2.7.4
> >
> 
> --
> Sakari Ailus
> sakari.ailus@xxxxxxxxxxxxxxx



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux