Re: [PATCH] media: venus: add debugfs support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Malathi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[cannot apply to v4.20]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Malathi-Gottam/media-venus-add-debugfs-support/20181228-160258
base:   git://linuxtv.org/media_tree.git master
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   In file included from include/linux/kernel.h:14,
                    from include/linux/clk.h:16,
                    from drivers/media//platform/qcom/venus/core.c:15:
   drivers/media//platform/qcom/venus/core.c: In function 'venus_debugfs_init_drv':
>> drivers/media//platform/qcom/venus/core.c:56:9: error: '__name' undeclared (first use in this function); did you mean 'dev_name'?
       dir, __name);                                         \
            ^~~~~~
   include/linux/printk.h:315:34: note: in definition of macro 'pr_info'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
                                     ^~~~~~~~~~~
   drivers/media//platform/qcom/venus/core.c:55:3: note: in expansion of macro 'dprintk'
      dprintk(ERR, "Failed creating debugfs file '%pd/%s'\n",  \
      ^~~~~~~
   drivers/media//platform/qcom/venus/core.c:63:2: note: in expansion of macro '__debugfs_create'
     __debugfs_create(x32, "debug_level", &venus_debug);
     ^~~~~~~~~~~~~~~~
   drivers/media//platform/qcom/venus/core.c:56:9: note: each undeclared identifier is reported only once for each function it appears in
       dir, __name);                                         \
            ^~~~~~
   include/linux/printk.h:315:34: note: in definition of macro 'pr_info'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
                                     ^~~~~~~~~~~
   drivers/media//platform/qcom/venus/core.c:55:3: note: in expansion of macro 'dprintk'
      dprintk(ERR, "Failed creating debugfs file '%pd/%s'\n",  \
      ^~~~~~~
   drivers/media//platform/qcom/venus/core.c:63:2: note: in expansion of macro '__debugfs_create'
     __debugfs_create(x32, "debug_level", &venus_debug);
     ^~~~~~~~~~~~~~~~
   In file included from include/linux/printk.h:7,
                    from include/linux/kernel.h:14,
                    from include/linux/clk.h:16,
                    from drivers/media//platform/qcom/venus/core.c:15:
   drivers/media//platform/qcom/venus/core.c: In function 'venus_clks_enable':
   include/linux/kern_levels.h:5:18: warning: format '%d' expects argument of type 'int', but argument 2 has type 'char *' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^~~~~~~~
   include/linux/printk.h:315:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~
   drivers/media//platform/qcom/venus/core.h:55:4: note: in expansion of macro 'pr_info'
       pr_info("venus:" fmt, \
       ^~~~~~~
   drivers/media//platform/qcom/venus/core.c:185:2: note: in expansion of macro 'dprintk'
     dprintk(ERR, "Failed to enable clk:%d\n", i);
     ^~~~~~~
   drivers/media//platform/qcom/venus/core.c:185:38: note: format string is defined here
     dprintk(ERR, "Failed to enable clk:%d\n", i);
                                        ~^
                                        %s
   In file included from include/linux/printk.h:7,
                    from include/linux/kernel.h:14,
                    from include/linux/clk.h:16,
                    from drivers/media//platform/qcom/venus/core.c:15:
   include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^~~~~~~~
   include/linux/printk.h:315:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~
   drivers/media//platform/qcom/venus/core.h:55:4: note: in expansion of macro 'pr_info'
       pr_info("venus:" fmt, \
       ^~~~~~~
   drivers/media//platform/qcom/venus/core.c:185:2: note: in expansion of macro 'dprintk'
     dprintk(ERR, "Failed to enable clk:%d\n", i);
     ^~~~~~~
   drivers/media//platform/qcom/venus/core.c: In function 'venus_probe':
   include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^~~~~~~~
   include/linux/printk.h:315:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~
   drivers/media//platform/qcom/venus/core.h:55:4: note: in expansion of macro 'pr_info'
       pr_info("venus:" fmt, \
       ^~~~~~~
   drivers/media//platform/qcom/venus/core.c:297:3: note: in expansion of macro 'dprintk'
      dprintk(ERR, "Failed to ioremap platform resources");
      ^~~~~~~
   include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^~~~~~~~
   include/linux/printk.h:315:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~
   drivers/media//platform/qcom/venus/core.h:55:4: note: in expansion of macro 'pr_info'
       pr_info("venus:" fmt, \
       ^~~~~~~
   drivers/media//platform/qcom/venus/core.c:351:3: note: in expansion of macro 'dprintk'
      dprintk(ERR, "Failed to init video firmware\n");
      ^~~~~~~
   include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~

vim +56 drivers/media//platform/qcom/venus/core.c

  > 15	#include <linux/clk.h>
    16	#include <linux/debugfs.h>
    17	#include <linux/init.h>
    18	#include <linux/ioctl.h>
    19	#include <linux/list.h>
    20	#include <linux/module.h>
    21	#include <linux/of_device.h>
    22	#include <linux/platform_device.h>
    23	#include <linux/slab.h>
    24	#include <linux/types.h>
    25	#include <linux/pm_runtime.h>
    26	#include <media/videobuf2-v4l2.h>
    27	#include <media/v4l2-mem2mem.h>
    28	#include <media/v4l2-ioctl.h>
    29	
    30	#include "core.h"
    31	#include "vdec.h"
    32	#include "venc.h"
    33	#include "firmware.h"
    34	
    35	struct dentry *debugfs_root;
    36	int venus_debug = ERR;
    37	EXPORT_SYMBOL_GPL(venus_debug);
    38	
    39	static struct dentry *venus_debugfs_init_drv(void)
    40	{
    41		bool ok = false;
    42		struct dentry *dir = NULL;
    43	
    44		dir = debugfs_create_dir("venus", NULL);
    45		if (IS_ERR_OR_NULL(dir)) {
    46			dir = NULL;
    47			pr_err("failed to create debug dir");
    48			goto failed_create_dir;
    49		}
    50	
    51	#define __debugfs_create(__type, __fname, __value) ({                          \
    52		struct dentry *f = debugfs_create_##__type(__fname, 0644,	\
    53			dir, __value);                                                \
    54		if (IS_ERR_OR_NULL(f)) {                                              \
    55			dprintk(ERR, "Failed creating debugfs file '%pd/%s'\n",  \
  > 56				dir, __name);                                         \
    57			f = NULL;                                                     \
    58		}                                                                     \
    59		f;                                                                    \
    60	})
    61	
    62		ok =
    63		__debugfs_create(x32, "debug_level", &venus_debug);
    64	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux