On Mon, Dec 3, 2018 at 2:14 PM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote:
>
> In the ov5640_try_frame_interval function, the ret variable actually holds
> the frame rate index to use, which is represented by the enum
> ov5640_frame_rate in the driver.
>
> Make it more obvious.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>
> Tested-by: Adam Ford <aford173@xxxxxxxxx> #imx6dq
> ---
> drivers/media/i2c/ov5640.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index abca08d669be..6cdf5ee0e4fa 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -2052,8 +2052,8 @@ static int ov5640_try_frame_interval(struct ov5640_dev *sensor,
> u32 width, u32 height)
> {
> const struct ov5640_mode_info *mode;
> + enum ov5640_frame_rate rate = OV5640_30_FPS;
This is breaking setting 15fps via media-ctl.
Initializing rate to OV5640_15_FPS will satisfy all fps rate changes.
