Hi Sakari, Thank you for the patch. On Thursday, 13 December 2018 12:40:06 EET Sakari Ailus wrote: > The size argument of the alloc memop, which allocates buffer memory, is > page aligned. Document it as such, as code elsewhere has not taken this > into account. > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > --- > include/media/videobuf2-core.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h > index e86981d615ae4..68b9fe660e4f1 100644 > --- a/include/media/videobuf2-core.h > +++ b/include/media/videobuf2-core.h > @@ -54,7 +54,8 @@ struct vb2_threadio_data; > * will then be passed as @buf_priv argument to other ops in this > * structure. Additional gfp_flags to use when allocating the > * are also passed to this operation. These flags are from the > - * gfp_flags field of vb2_queue. > + * gfp_flags field of vb2_queue. The size argument to this function > + * shall be *page aligned*. > * @put: inform the allocator that the buffer will no longer be used; > * usually will result in the allocator freeing the buffer (if > * no other users of this buffer are present); the @buf_priv I wonder if a WARN_ON() to ensure this would make sense. In any case, Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> -- Regards, Laurent Pinchart
