Hi Bingbu, On Thu, Dec 13, 2018 at 01:35:08PM +0800, Bingbu Cao wrote: > > > On 12/12/2018 07:49 PM, Sakari Ailus wrote: > > Address the following warnings by setting the entity's function to an > > appropriate value. > > > > [ 5.043377] ipu3-cio2 0000:00:14.3: Entity type for entity ipu3-csi2 0 was not initialized! > > [ 5.043427] ipu3-cio2 0000:00:14.3: Entity type for entity ipu3-csi2 1 was not initialized! > > [ 5.043463] ipu3-cio2 0000:00:14.3: Entity type for entity ipu3-csi2 2 was not initialized! > > [ 5.043502] ipu3-cio2 0000:00:14.3: Entity type for entity ipu3-csi2 3 was not initialized! > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > --- > > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > > index 447baaebca448..e827e12b9718f 100644 > > --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c > > +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > > @@ -1597,6 +1597,7 @@ static int cio2_queue_init(struct cio2_device *cio2, struct cio2_queue *q) > > /* Initialize subdev */ > > v4l2_subdev_init(subdev, &cio2_subdev_ops); > > + subdev->entity.function = MEDIA_ENT_F_VID_IF_BRIDGE; > I am wondering what is the difference between VID_IF_BRIDGE and PROC_VIDEO_PIXEL_FORMATTER. > Some CSI-2 receiver is using PIXEL_FORMATTER now. Good question. Based on the documentation neither perfectly fits: <URL:https://hverkuil.home.xs4all.nl/spec/uapi/mediactl/media-types.html#media-entity-functions> Ideally it should be possible for it to be both at the same time, but the API currently allows only one. > > subdev->flags = V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS; > > subdev->owner = THIS_MODULE; > > snprintf(subdev->name, sizeof(subdev->name), > -- Regards, Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
