Hi Sakari, Bingbu,
On Mon, Dec 3, 2018 at 7:25 PM Sakari Ailus
<sakari.ailus@xxxxxxxxxxxxxxx> wrote:
>
> Hi Bing Bu, Tomasz,
>
> On Mon, Dec 03, 2018 at 10:53:34AM +0800, Bingbu Cao wrote:
> >
> >
> > On 12/01/2018 02:08 AM, Tomasz Figa wrote:
> > > Hi Bingbu,
> > >
> > > On Mon, Nov 26, 2018 at 7:56 PM <bingbu.cao@xxxxxxxxx> wrote:
> > > > From: Bingbu Cao <bingbu.cao@xxxxxxxxx>
> > > >
> > > > Some Sony camera sensors have same test pattern
> > > > definitions, this patch unify the pattern naming
> > > > to make it more clear to the userspace.
> > > >
> > > > Suggested-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > > > Signed-off-by: Bingbu Cao <bingbu.cao@xxxxxxxxx>
> > > > ---
> > > > drivers/media/i2c/imx258.c | 8 ++++----
> > > > drivers/media/i2c/imx319.c | 8 ++++----
> > > > drivers/media/i2c/imx355.c | 8 ++++----
> > > > 3 files changed, 12 insertions(+), 12 deletions(-)
> > > >
> > > Thanks for the patch! One comment inline.
> > >
> > > > diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c
> > > > index 31a1e2294843..a8a2880c6b4e 100644
> > > > --- a/drivers/media/i2c/imx258.c
> > > > +++ b/drivers/media/i2c/imx258.c
> > > > @@ -504,10 +504,10 @@ struct imx258_mode {
> > > >
> > > > static const char * const imx258_test_pattern_menu[] = {
> > > > "Disabled",
> > > > - "Color Bars",
> > > > - "Solid Color",
> > > > - "Grey Color Bars",
> > > > - "PN9"
> > > > + "Solid Colour",
> > > > + "Eight Vertical Colour Bars",
> > > Is it just me or "solid color" and "color bars" are being swapped
> > > here? Did the driver had the names mixed up before or the order of
> > > modes is different between these sensors?
> > The test pattern value order of the 3 camera sensors should be same.
> > All are:
> > 0 - Disabled
> > 1 - Solid Colour
> > 2 - Eight Vertical Colour Bars
> > ...
> >
> > This patch swapped the first 2 item for imx258 (wrong order before) and use unified
> > name for all 3 sensors.
>
> I guess this isn't based on Jason's patch (now merged) that fixed the
> issue. I'll rebase this; it's trivial.
Thanks for clarifying.
Best regards,
Tomasz
