Hi Helen, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.20-rc5 next-20181207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Helen-Koike/media-vimc-add-configfs-API-to-configure-the-topology/20181208-071726 base: git://linuxtv.org/media_tree.git master config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm All warnings (new ones prefixed by >>): In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:14, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/media//platform/vimc/vimc-configfs.c:9: drivers/media//platform/vimc/vimc-configfs.c: In function 'vimc_cfs_link_make_item': include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'unsigned int' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH' #define KERN_ERR KERN_SOH "3" /* error conditions */ ^~~~~~~~ include/linux/printk.h:308:9: note: in expansion of macro 'KERN_ERR' printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~ >> drivers/media//platform/vimc/vimc-configfs.c:22:2: note: in expansion of macro 'pr_err' pr_err("vimc: %s: " pr_fmt(fmt), (ci)->ci_name, ##__VA_ARGS__) ^~~~~~ >> drivers/media//platform/vimc/vimc-configfs.c:23:25: note: in expansion of macro 'ci_err' #define cg_err(cg, ...) ci_err(&(cg)->cg_item, ##__VA_ARGS__) ^~~~~~ >> drivers/media//platform/vimc/vimc-configfs.c:323:3: note: in expansion of macro 'cg_err' cg_err(&cfs->gdev, ^~~~~~ drivers/media//platform/vimc/vimc-configfs.c:324:32: note: format string is defined here "Pad with more then %ld digits is not supported", ~~^ %d In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:14, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/media//platform/vimc/vimc-configfs.c:9: drivers/media//platform/vimc/vimc-configfs.c: In function 'vimc_cfs_ent_make_group': include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'unsigned int' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH' #define KERN_ERR KERN_SOH "3" /* error conditions */ ^~~~~~~~ include/linux/printk.h:308:9: note: in expansion of macro 'KERN_ERR' printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~ >> drivers/media//platform/vimc/vimc-configfs.c:22:2: note: in expansion of macro 'pr_err' pr_err("vimc: %s: " pr_fmt(fmt), (ci)->ci_name, ##__VA_ARGS__) ^~~~~~ >> drivers/media//platform/vimc/vimc-configfs.c:23:25: note: in expansion of macro 'ci_err' #define cg_err(cg, ...) ci_err(&(cg)->cg_item, ##__VA_ARGS__) ^~~~~~ drivers/media//platform/vimc/vimc-configfs.c:443:3: note: in expansion of macro 'cg_err' cg_err(&cfs->gdev, ^~~~~~ drivers/media//platform/vimc/vimc-configfs.c:444:56: note: format string is defined here "%s: Driver name length should be less then %ld.", ~~^ %d vim +/pr_err +22 drivers/media//platform/vimc/vimc-configfs.c 20 21 #define ci_err(ci, fmt, ...) \ > 22 pr_err("vimc: %s: " pr_fmt(fmt), (ci)->ci_name, ##__VA_ARGS__) > 23 #define cg_err(cg, ...) ci_err(&(cg)->cg_item, ##__VA_ARGS__) 24 #define ci_warn(ci, fmt, ...) \ 25 pr_warn("vimc: %s: " pr_fmt(fmt), (ci)->ci_name, ##__VA_ARGS__) 26 #define cg_warn(cg, ...) ci_warn(&(cg)->cg_item, ##__VA_ARGS__) 27 #define ci_dbg(ci, fmt, ...) \ 28 pr_debug("vimc: %s: " pr_fmt(fmt), (ci)->ci_name, ##__VA_ARGS__) 29 #define cg_dbg(cg, ...) ci_dbg(&(cg)->cg_item, ##__VA_ARGS__) 30 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
