Hi Chen-Yu, On Mon, Dec 03, 2018 at 05:48:31PM +0800, Chen-Yu Tsai wrote: > On Mon, Dec 3, 2018 at 5:42 PM Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > On Fri, Nov 30, 2018 at 1:29 PM Chen-Yu Tsai <wens@xxxxxxxx> wrote: > > > > > > The CSI controller found on the H3 (and H5) is a reduced version of the > > > one found on the A31. It only has 1 channel, instead of 4 channels for > > > time-multiplexed BT.656. Since the H3 is a reduced version, it cannot > > > "fallback" to a compatible that implements more features than it > > > supports. > > > > > > Split out the H3 compatible as a separate entry, with no fallback. > > > > > > Fixes: b7eadaa3a02a ("media: dt-bindings: media: sun6i: Add A31 and H3 > > > compatibles") > > > Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx> > > > > "media" text appear two times on commit head. > > Just following what previous commits did. :) I understand Mauro has a script prefixes everything going through the media tree with "media: " unless it's already there. I'd drop the latter, but perhaps elaborate a bit this is about CSI. Fine details... I think it's fine as-is for now. > > > Reviewed-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > > BTW, I know you've been trying to get CSI to work on the A64. > I have it working for the Bananapi-M64. The CSI SCLK needs to > be lowered to 300 MHz or the image gets corrupted. > > ChenYu -- Sakari Ailus