Hi, Laurent, Thanks for the review. > -----Original Message----- > From: Laurent Pinchart [mailto:laurent.pinchart@xxxxxxxxxxxxxxxx] > Sent: Thursday, November 29, 2018 1:17 PM > To: Zhi, Yong <yong.zhi@xxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx; sakari.ailus@xxxxxxxxxxxxxxx; > tfiga@xxxxxxxxxxxx; mchehab@xxxxxxxxxx; hans.verkuil@xxxxxxxxx; Mani, > Rajmohan <rajmohan.mani@xxxxxxxxx>; Zheng, Jian Xu > <jian.xu.zheng@xxxxxxxxx>; Hu, Jerry W <jerry.w.hu@xxxxxxxxx>; Toivonen, > Tuukka <tuukka.toivonen@xxxxxxxxx>; Qiu, Tian Shu > <tian.shu.qiu@xxxxxxxxx>; Cao, Bingbu <bingbu.cao@xxxxxxxxx> > Subject: Re: [PATCH v7 01/16] v4l: Add Intel IPU3 meta buffer formats > > Hello Yong, > > Thank you for the patch. > > On Tuesday, 30 October 2018 00:22:55 EET Yong Zhi wrote: > > Add IPU3-specific meta formats for parameter processing and 3A, DVS > > statistics: > > Unless I'm mistaken DVS support has been removed. You can write this as > > Add IPU3-specific meta formats for processing parameters and 3A statistics. > Ack. > > > > V4L2_META_FMT_IPU3_PARAMS > > V4L2_META_FMT_IPU3_STAT_3A > > > > Signed-off-by: Yong Zhi <yong.zhi@xxxxxxxxx> > > --- > > drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ > > include/uapi/linux/videodev2.h | 4 ++++ > > 2 files changed, 6 insertions(+) > > I would squash this with patch 03/16. > OK, will squash patch 01 and 03 into single patch for v8. > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c > > b/drivers/media/v4l2-core/v4l2-ioctl.c index 6489f25..abff64b 100644 > > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > > @@ -1299,6 +1299,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc > *fmt) > > case V4L2_META_FMT_VSP1_HGO: descr = "R-Car VSP1 1-D Histogram"; > break; > > case V4L2_META_FMT_VSP1_HGT: descr = "R-Car VSP1 2-D Histogram"; > break; > > case V4L2_META_FMT_UVC: descr = "UVC payload header > metadata"; break; > > + case V4L2_META_FMT_IPU3_PARAMS: descr = "IPU3 processing > parameters"; > > break; > > + case V4L2_META_FMT_IPU3_STAT_3A: descr = "IPU3 3A statistics"; > break; > > > > default: > > /* Compressed formats */ > > diff --git a/include/uapi/linux/videodev2.h > > b/include/uapi/linux/videodev2.h index f0a968a..bdccd7a 100644 > > --- a/include/uapi/linux/videodev2.h > > +++ b/include/uapi/linux/videodev2.h > > @@ -718,6 +718,10 @@ struct v4l2_pix_format { > > #define V4L2_META_FMT_UVC v4l2_fourcc('U', 'V', 'C', 'H') /* UVC > > Payload Header metadata */ #define V4L2_META_FMT_D4XX > > v4l2_fourcc('D', '4', 'X', 'X') /* D4XX Payload Header metadata */ > > > > +/* Vendor specific - used for IPU3 camera sub-system */ > > +#define V4L2_META_FMT_IPU3_PARAMS v4l2_fourcc('i', 'p', '3', 'p') /* > IPU3 > > params */ > > Maybe "IPU3 processing parameters" in full ? > Ack, thanks!! > Apart from that the patch looks good to me. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > +#define V4L2_META_FMT_IPU3_STAT_3A v4l2_fourcc('i', 'p', '3', 's') /* > IPU3 > > 3A statistics */ > > + > > /* priv field value to indicates that subsequent fields are valid. */ > > #define V4L2_PIX_FMT_PRIV_MAGIC 0xfeedcafe > > > -- > Regards, > > Laurent Pinchart > >
