On Tue, Nov 27, 2018 at 10:09:08AM +0100, Luca Ceresoli wrote: > Hi Sakari, > > On 27/11/18 09:38, Sakari Ailus wrote: > > Hi Luca, > > > > On Tue, Nov 27, 2018 at 09:34:43AM +0100, Luca Ceresoli wrote: > >> The V4L2_SUBDEV_FL_HAS_EVENTS flag should not be set, event are just > >> not implemented. > >> > >> Signed-off-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx> > > > > The driver supports controls, and so control events can be subscribed and > > received by the user. Therefore I don't see a reason to remove the flag. I further missed the driver does not set the event (un)subscription callbacks; the event support is actually not functional as a result. :-\ It's trivial to do that, see e.g. the imx319 driver. > > Thanks, good to know. > > Would it be worth adding a note where V4L2_SUBDEV_FL_HAS_EVENTS is > #defined, to make this clear? Could you send a patch? A few words should be enough, no need for a too elaborate description I guess. -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx
