Hi Hans, Em Thu, 22 Nov 2018 23:26:07 +0100 Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > On 11/22/2018 09:52 PM, Mauro Carvalho Chehab wrote: > > Em Tue, 8 May 2018 12:48:45 +0200 > > Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > > > >> Fixes/improvements all over the place. > >> > >> Changes since v1: > >> > >> Replaced "media: media-device: fix ioctl function types" with the v2 version > >> of that patch. My fault, I missed Sakari's request for a change of v1. > > > > You should seriously review how you're adding SOBs... there are > > even some like: > > > > Signed-off-by Hans Verkuil <hans.verkuil> > > Reported-by: syzbot+69780d144754b8071f4b@xxxxxxxxxxxxxxxxxxxxxxxxx > > Cc: <stable@xxxxxxxxxxxxxxx> # for v4.20 and up > > Signed-off-by Hans Verkuil <hansverk@xxxxxxxxx> > > You seem to have replied to a different git pull request (v4.18?!) then > what these lines above indicate, but it appears that this refers to patch > "vim2m: use cancel_delayed_work_sync instead of flush_schedule_work". > > It looks like I just completely mistyped the SoB in that patch. Nothing to do > with the xs4all vs cisco SoBs and AFAICS it is an issue just with that patch. > > Regarding those, the core problem is that I want to show that what I'm doing is > paid for by Cisco, but I don't want to use the cisco email address to actually > send patches, pull requests, etc., since that requires a vpn which is really annoying. > > I've made a new email alias hverkuil-cisco@xxxxxxxxx (I'm not allowed to use a '+' > unfortunately) and I think I will use that as my git email address to avoid > cisco.com entirely. Yeah, I know the drill. I had to do about the same in order to mark that my work is sponsored by Samsung. > Regarding the outstanding pull requests with SoB/Author mismatches: should I redo > those and repost? It's a pain, but if you want it I'll do that tomorrow. Yes, please. If it was just to remove a duplicated SoB from another e-mail (or a typo outside the e-mail part), I would gladly do when merging (probably using git filter or something scripteable tooling), but I don't feel comfortable to replace an e-mail address on commits. Thanks, Mauro
