Hi Rui, On Wed, Nov 21, 2018 at 10:59:55AM +0000, Rui Miguel Silva wrote: > Swapping the order between v4l2 subdevice registration and checking chip id in > b7a417628abf ("media: ov2680: don't register the v4l2 subdevice before checking chip ID") > makes the mode restore to use the sensor controls before they are set, so move > the mode restore call to s_power after the handler setup for controls is done. > > This remove also the need for the error code path in power on function. Could you make sure you wrap the lines in the commit at 76 or so? Otherwise they'll wrap in git log. I've re-wrapped it this time. Thanks. -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx