Hi! On Mon, Nov 19, 2018 at 03:58:34PM +0200, Sakari Ailus wrote: > > + /** > > + * @clk_pre: > > + * > > + * Time, in nanoseconds, that the HS clock shall be driven by > > + * the transmitter prior to any associated Data Lane beginning > > + * the transition from LP to HS mode. > > + */ > > + unsigned int clk_pre; > > Is the unit of clk_pre intended to be UI or ns? You're right, it's in UI. > How about adding information on the limits of these values as well? I usually feel like the more you duplicate informations, the higher the chances are to do a mistake and that becomes a burden to maintain over time, but if you feel like it would be best, i'll do it. > > + /** > > + * @lanes: > > + * > > + * Number of lanes used for the transmissions. > > + */ > > + unsigned char lanes; > > This is related to the data_lanes DT property. I assume this is intended to > be the number of active lanes. And presumably the first "lanes" number of > lanes would be used in that case? I'm not sure I got your question, sorry. But yes, this is the number of active lanes. In the v4l2 world, chances are that this is going to come from the data lanes property, in DRM this is coming from the panel structure. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
