Hi Hans, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.20-rc3 next-20181120] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-Verkuil/videodev2-h-add-V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF-CREATE_BUFS/20181120-190153 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-x070-201846 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from include/linux/err.h:5:0, from drivers/media/common/videobuf2/videobuf2-v4l2.c:17: drivers/media/common/videobuf2/videobuf2-v4l2.c: In function 'fill_buf_caps_vdev': drivers/media/common/videobuf2/videobuf2-v4l2.c:878:21: error: dereferencing pointer to incomplete type 'const struct v4l2_ioctl_ops' if (vdev->ioctl_ops->vidioc_prepare_buf) ^ include/linux/compiler.h:58:30: note: in definition of macro '__trace_if' if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^~~~ >> drivers/media/common/videobuf2/videobuf2-v4l2.c:878:2: note: in expansion of macro 'if' if (vdev->ioctl_ops->vidioc_prepare_buf) ^~ vim +/if +878 drivers/media/common/videobuf2/videobuf2-v4l2.c 873 874 static void fill_buf_caps_vdev(struct video_device *vdev, u32 *caps) 875 { 876 *caps = 0; 877 fill_buf_caps(vdev->queue, caps); > 878 if (vdev->ioctl_ops->vidioc_prepare_buf) 879 *caps |= V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF; 880 if (vdev->ioctl_ops->vidioc_create_bufs) 881 *caps |= V4L2_BUF_CAP_SUPPORTS_CREATE_BUFS; 882 } 883 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
