On 11/13/18 16:19, Joe Perches wrote: > On Tue, 2018-11-13 at 13:24 +0100, Hans Verkuil wrote: >> On 11/13/18 09:24, Maxime Ripard wrote: >>> The older CSI drivers have camera capture interface different from the one >>> in the newer ones. > [] >>> diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h > [] >>> + // Videobuf2 >> >> Doesn't checkpatch.pl --strict complain about the use of '//'? > > No, not since > > commit dadf680de3c2eb4cba9840619991eda0cfe98778 > Author: Joe Perches <joe@xxxxxxxxxxx> > Date: Tue Aug 2 14:04:33 2016 -0700 > > checkpatch: allow c99 style // comments > > Sanitise the lines that contain c99 comments so that the error doesn't > get emitted. > > Huh, I'm really out of date. But the good news is that I learned something new today! Thank you, Hans