Hi Steve, On Thu, 2018-11-08 at 21:46 -0800, Steve Longerbeam wrote: > > diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c > > index c4523afe7b48..d39682192a67 100644 > > --- a/drivers/staging/media/imx/imx-media-csi.c > > +++ b/drivers/staging/media/imx/imx-media-csi.c > > @@ -41,7 +41,7 @@ > > #define MIN_H 144 > > #define MAX_W 4096 > > #define MAX_H 4096 > > -#define W_ALIGN 4 /* multiple of 16 pixels */ > > +#define W_ALIGN 1 /* multiple of 2 pixels */ > > This works for the IDMAC output pad because the channel's cpmem width > and stride can be rounded up, but width align at the CSI sink still > needs to be 8 pixels when directed to the IC via the CSI_SRC_PAD_DIRECT > pad, in order to support the 8x8 block rotator in the IC PRP, and > there's no way AFAIK to do the same trick of rounding up width andq > stride for non-IDMAC direct paths through the IPU. Can't we just disallow rotation on prp subdevs if sink format is not aligned to 2^3? Another possibility would be to align sink pad format width to 2^3 only if the PAD_DIRECT link is enabled. > Also, the imx-ic-prpencvf.c W_ALIGN_SRC can be relaxed to 2 pixels as > well. True, added for v2. regards Philipp
