On Thu, 8 Nov 2018 at 14:54, Sasha Levin <sashal@xxxxxxxxxx> wrote: > > On Thu, Nov 08, 2018 at 10:10:10AM +0200, Dafna Hirschfeld wrote: > >On Thu, Nov 8, 2018 at 2:51 AM Ezequiel Garcia < > >ezequiel@xxxxxxxxxxxxxxxxxxxx> wrote: > > > >> Hello Dafna, > >> > >> Thanks for the patches. > >> > >> Just out of curiosity. Why these patches havent't been submitted to > >> the media mailing list? > >> > >> Hi, > >I wasn't sure if I should send it to the media mailing list, since this > >part of outreachy application. > > In general, for any patch you send to any subsystem please Cc all the > relevant mailing lists and maintainers. For Outreachy application you > already did that (by Cc'ing Greg), you just need to keep doing the same > as you continue your work on other parts of the kernel. > Let's Cc the mailing list now, as these patches look good, and the test scripts look pretty decent too ;-) > >Also, how are you testing these changes? > >> > > > >Based on Helen's decoder: > >https://gitlab.collabora.com/koike/v4l2-codec > > > >I extended it to include encoders and decoders for the new supported > >formats. > > > >testing formats with alpha plane: > >https://github.com/kamomil/outreachy/blob/master/argb-and-abgr-full-example.sh > > > >testing greyscale: > >https://github.com/kamomil/outreachy/blob/master/greyscale-full-example.sh > > It's awesome seeing these testsuites, it gives reviewers confidence that > your patch is well tested and they can focus on other parts of the > review process rather than check for the basic correctness of the patch. > > Please include links such as these and indicate how you tested your code > in your future patches. > +1 Thanks! -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar
