Hi Sylwester, On 11/02/2018 05:16 PM, Sylwester Nawrocki wrote: > Hi Hans, > > On Fri, 5 Oct 2018 at 09:49, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: >> >> From: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> >> This patch series converts the last remaining drivers that use g/s_crop and >> cropcap to g/s_selection. > > Thank you for this clean up! I remember attempting conversion of those remaining > drivers to selection API long time ago but I didn't have a good idea > then how to address > that crop and compose target inversion mess so I abandoned that efforts then. Thank you for the review. One question: have you also tested this with at least one of the affected drivers? I'd like to have at least one Tested-by line. Regards, Hans