On 10/31/2018 10:40 AM, Mauro Carvalho Chehab wrote: > Em Wed, 31 Oct 2018 11:29:45 +0200 > Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> escreveu: > >> Hi Mauro, >> >> On Tue, Oct 30, 2018 at 09:06:18AM -0300, Mauro Carvalho Chehab wrote: >>> Em Tue, 30 Oct 2018 01:00:29 +0200 >>> Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> escreveu: >>> >>>> Clean up the SoC camera framework header. It only exists now to keep board >>>> code compiling. The header can be removed once the board code dependencies >>>> to it has been removed. >>>> >>>> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> >>>> --- >>>> include/media/soc_camera.h | 335 --------------------------------------------- >>>> 1 file changed, 335 deletions(-) >>>> >>>> diff --git a/include/media/soc_camera.h b/include/media/soc_camera.h >>>> index b7e42a1b0910..14d19da6052a 100644 >>>> --- a/include/media/soc_camera.h >>>> +++ b/include/media/soc_camera.h >>>> @@ -22,172 +22,6 @@ >>>> #include <media/v4l2-ctrls.h> >>>> #include <media/v4l2-device.h> >>> >>> That doesn't make any sense. soc_camera.h should have the same fate >>> as the entire soc_camera infrastructure: either be removed or moved >>> to staging, and everything else that doesn't have the same fate >>> should get rid of this header. >> >> We can't just remove this; there is board code that depends on it. >> >> The intent is to remove the board code as well but presuming that the board >> code would be merged through a different tree, it'd be less hassle to wait >> a bit; hence the patch removing any unnecessary stuff here. > > Then we need *first* to remove board code, wait for those changes to be > applied and *then* remove soc_camera (and not the opposite). Please note that the camera support for all the remaining boards using soc_camera has been dead for years. The soc_camera drivers that they depended on have been removed a long time ago. So all they depend on are the header. We can safely remove soc_camera without loss of functionality (and thus prevent others from basing new drivers on soc_camera), while we work to update the board files so we can remove this last header. I have modified some board files here: https://git.linuxtv.org/hverkuil/media_tree.git/commit/?h=rm-soc-camera&id=d7ae2fcf6e447022f0780bb86a2b63d5c7cf4d35 Only arch/arm/mach-imx/mach-imx27_visstrim_m10.c hasn't been fixed yet in that patch (ENOTIME). The problem is just lack of time to clean this up and figure out who should take these board patches. So I think it is a nice solution to just replace the header with a dummy version so the board files still compile, and then we can delete the dead soc_camera driver. It's probably easier as well to push through the board file changes once soc_camera is removed since you can just point out that the framework it depended on is gone. Regards, Hans
