Hi Hans, On Fri, Oct 05, 2018 at 09:49:00AM +0200, Hans Verkuil wrote: > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > This patch series converts the last remaining drivers that use g/s_crop and > cropcap to g/s_selection. > > The first two patches do some minor code cleanup. > > The third patch adds a new video_device flag to indicate that the driver > inverts the normal usage of g/s_crop/cropcap. This applies to the old > Samsung drivers that predate the Selection API and that abused the existing > crop API. > > The next three patches do some code cleanup and prepare drivers for the > removal of g/s_crop and ensure that cropcap only returns the pixelaspect. > > The next three patches convert the remaining Samsung drivers and set the > QUIRK flag for all three. > > The final two patches remove vidioc_g/s_crop and rename vidioc_cropcap > to vidioc_g_pixelaspect. Nice one; thanks! For patches 1, 2, 3, 10 and 11: Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> I didn't read through the driver changes but I assume they would be fine. :-) -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx