On 04/10/18 12:09, Hans Verkuil wrote: > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > The HDMI_CEC_DBG_3 register does have a retransmit count, but you > can't write to it, those bits are read-only. > > So drop the attempt to set the retransmit count, since it doesn't > work. > > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > --- > drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c > index dee66a5101b5..00407f1995a8 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c > @@ -280,9 +280,6 @@ static int hdmi_cec_adap_transmit(struct cec_adapter *adap, u8 attempts, > hdmi_write_reg(core->base, HDMI_CEC_INT_STATUS_1, > HDMI_CEC_RETRANSMIT_CNT_INT_MASK); > > - /* Set the retry count */ > - REG_FLD_MOD(core->base, HDMI_CEC_DBG_3, attempts - 1, 6, 4); > - I presume there's no harm in having a different retry count in the HW than what was requested via the API? Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
