On 10/07/2018 01:03 AM, Sasha Levin wrote: > On Sat, Oct 06, 2018 at 10:21:38PM +0300, Dafna Hirschfeld wrote: >> Replace calls to `printk` with the appropriate `pr_*` >> macro. > > Hi Dafna, > > I'd encourage you to look into the dev_ family of print functions (such > as dev_info() ). They can avoid having to repeat the driver name in > every print call. Not for this driver. The hdw->name is the right prefix to use and the code already uses it. For almost any other media driver Sasha would be right, just not this one due to historical reasons. Regards, Hans
