Hi Hans, Thanks for your work. On 2018-10-05 09:49:01 +0200, Hans Verkuil wrote: > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > Drop the deprecated _ACTIVE part. > > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > index 7de041bae84f..9c2370e4d05c 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > @@ -2212,9 +2212,9 @@ static int v4l_g_crop(const struct v4l2_ioctl_ops *ops, > > /* crop means compose for output devices */ > if (V4L2_TYPE_IS_OUTPUT(p->type)) > - s.target = V4L2_SEL_TGT_COMPOSE_ACTIVE; > + s.target = V4L2_SEL_TGT_COMPOSE; > else > - s.target = V4L2_SEL_TGT_CROP_ACTIVE; > + s.target = V4L2_SEL_TGT_CROP; > > ret = v4l_g_selection(ops, file, fh, &s); > > @@ -2239,9 +2239,9 @@ static int v4l_s_crop(const struct v4l2_ioctl_ops *ops, > > /* crop means compose for output devices */ > if (V4L2_TYPE_IS_OUTPUT(p->type)) > - s.target = V4L2_SEL_TGT_COMPOSE_ACTIVE; > + s.target = V4L2_SEL_TGT_COMPOSE; > else > - s.target = V4L2_SEL_TGT_CROP_ACTIVE; > + s.target = V4L2_SEL_TGT_CROP; > > return v4l_s_selection(ops, file, fh, &s); > } > -- > 2.18.0 > -- Regards, Niklas Söderlund