The fwnode patchset added a several new warnings, as identified by
checkpatch.pl --strict.
Those are at the core stuff, and makes harder to review patches there.
The most irritating stuff there are functions like:
some_very_long_function_that_has_a_very_comprehensive_name(
...);
Functions ending with a "(" without arguments doesn't follow the
right coding style, and it is an heritage of the usage of "indent".
Ok, it sounds that the patches were actually trying to follow an existing
coding style inside it.
As we're about to close the media merge window, and the fwnode patches
already changed a lot of code there, before that becomes an habit to
follow its weird style, let's fix it.
After this series, all we have is the lack of SPDX inside the sources,
and some long lines (with is inevitable without renaming those kAPI
functions).
Btw, I was tempted to rename them, renaming functions like:
v4l2_async_notifier_parse_fwnode_endpoints_by_port
to something like:
v4l2_async_parse_fwnode_ep_by_port
or even:
v4l2_parse_fwnode_ep_by_port
with is probably good enough, but, as this is part of the kAPI, I
opted to keep it as-is - for now.
Mauro Carvalho Chehab (3):
media: v4l2-core: cleanup coding style at V4L2 async/fwnode
media: v4l2-fwnode: cleanup functions that parse endpoints
media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props()
call
drivers/media/v4l2-core/v4l2-async.c | 45 +++---
drivers/media/v4l2-core/v4l2-fwnode.c | 190 ++++++++++++++------------
include/media/v4l2-async.h | 12 +-
include/media/v4l2-fwnode.h | 45 +++---
include/media/v4l2-mediabus.h | 32 +++--
5 files changed, 177 insertions(+), 147 deletions(-)
--
2.17.1
