Hi Vikash, On 09/19/2018 02:43 AM, Vikash Garodia wrote: > From: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx> > > This registers a firmware platform_device and associate it with > video-firmware DT subnode. Then calls dma configure to initialize > dma and iommu. Please replace the description with something like this: This registers a firmware platform_device and associates it with video-firmware DT subnode, by that way we are able to parse iommu configuration. > > Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx> > --- > drivers/media/platform/qcom/venus/core.c | 14 +++++--- > drivers/media/platform/qcom/venus/core.h | 3 ++ > drivers/media/platform/qcom/venus/firmware.c | 54 ++++++++++++++++++++++++++++ > drivers/media/platform/qcom/venus/firmware.h | 2 ++ > 4 files changed, 69 insertions(+), 4 deletions(-) > -- regards, Stan