Hi Nathan, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nathan-Chancellor/media-cx18-Don-t-check-for-address-of-video_dev/20180922-192000 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-x077-201837 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): In file included from include/linux/kernel.h:10:0, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/media/pci/cx18/cx18-driver.h:23, from drivers/media/pci/cx18/cx18-driver.c:20: drivers/media/pci/cx18/cx18-driver.c: In function 'cx18_cancel_out_work_orders': >> include/linux/compiler.h:58:28: error: wrong type argument to unary exclamation mark if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^ include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if' #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) ) ^~~~~~~~~~ >> drivers/media/pci/cx18/cx18-driver.c:1255:3: note: in expansion of macro 'if' if (cx->streams[i].video_dev) ^~ include/linux/compiler.h:58:40: error: wrong type argument to unary exclamation mark if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^ include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if' #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) ) ^~~~~~~~~~ >> drivers/media/pci/cx18/cx18-driver.c:1255:3: note: in expansion of macro 'if' if (cx->streams[i].video_dev) ^~ include/linux/compiler.h:69:14: error: wrong type argument to unary exclamation mark ______r = !!(cond); \ ^ include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if' #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) ) ^~~~~~~~~~ >> drivers/media/pci/cx18/cx18-driver.c:1255:3: note: in expansion of macro 'if' if (cx->streams[i].video_dev) ^~ -- In file included from include/linux/kernel.h:10:0, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/media//pci/cx18/cx18-driver.h:23, from drivers/media//pci/cx18/cx18-driver.c:20: drivers/media//pci/cx18/cx18-driver.c: In function 'cx18_cancel_out_work_orders': >> include/linux/compiler.h:58:28: error: wrong type argument to unary exclamation mark if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^ include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if' #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) ) ^~~~~~~~~~ drivers/media//pci/cx18/cx18-driver.c:1255:3: note: in expansion of macro 'if' if (cx->streams[i].video_dev) ^~ include/linux/compiler.h:58:40: error: wrong type argument to unary exclamation mark if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^ include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if' #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) ) ^~~~~~~~~~ drivers/media//pci/cx18/cx18-driver.c:1255:3: note: in expansion of macro 'if' if (cx->streams[i].video_dev) ^~ include/linux/compiler.h:69:14: error: wrong type argument to unary exclamation mark ______r = !!(cond); \ ^ include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if' #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) ) ^~~~~~~~~~ drivers/media//pci/cx18/cx18-driver.c:1255:3: note: in expansion of macro 'if' if (cx->streams[i].video_dev) ^~ vim +/if +1255 drivers/media/pci/cx18/cx18-driver.c 1250 1251 static void cx18_cancel_out_work_orders(struct cx18 *cx) 1252 { 1253 int i; 1254 for (i = 0; i < CX18_MAX_STREAMS; i++) > 1255 if (cx->streams[i].video_dev) 1256 cancel_work_sync(&cx->streams[i].out_work_order); 1257 } 1258 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
