On 09/14/2018 12:31 PM, Hans Verkuil wrote:
On 09/14/2018 05:22 PM, Eddie James wrote:
+static int aspeed_video_allocate_cma(struct aspeed_video *video)
<snip>
+ if (rc) {
+ v4l2_device_unregister(v4l2_dev);
+ dev_err(video->dev, "Failed to register video device\n");
+ return rc;
+ }
+
+ video->v4l2_fmt.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+ video->v4l2_fmt.fmt.pix.pixelformat = V4L2_PIX_FMT_JPEG;
+ video->v4l2_fmt.fmt.pix.field = V4L2_FIELD_NONE;
+ video->v4l2_fmt.fmt.pix.colorspace = V4L2_COLORSPACE_JPEG;
COLORSPACE_JPEG is deprecated. Use V4L2_COLORSPACE_SRGB for pix.colorspace
and set pix.quantization to V4L2_QUANTIZATION_FULL_RANGE.
FYI I'm getting a v4l2-compliance failure using your suggestion:
Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
test VIDIOC_G/S_PARM: OK
test VIDIOC_G_FBUF: OK (Not Supported)
fail:
../../../v4l-utils-1.12.3/utils/v4l2-compliance/v4l2-test-formats.cpp(331):
pixelformat == V4L2_PIX_FMT_JPEG && colorspace != V4L2_COLORSPACE_JPEG
fail:
../../../v4l-utils-1.12.3/utils/v4l2-compliance/v4l2-test-formats.cpp(436):
testColorspace(pix.pixelformat, pix.colorspace, pix.ycbcr_enc,
pix.quantization)
test VIDIOC_G_FMT: FAIL
This is with v4l-utils commit d977e20a45a03543c4bdfeb3aef5211446de7398.
+
+ /* Don't fail the probe if controls init fails */
+ v4l2_ctrl_handler_init(&video->v4l2_ctrl, 2);
+
<snip>
ve,
+};
+
+module_platform_driver(aspeed_video_driver);
+
+MODULE_DESCRIPTION("ASPEED Video Engine Driver");
+MODULE_AUTHOR("Eddie James");
+MODULE_LICENSE("GPL v2");
I don't like the read() API here. It is not a real read() either since it assumes
userspace reads full frames at a time. But if you read e.g. one byte at a time,
then each byte is just the first byte of a different frame.
Yea...
I think we need to figure out how to make the stream I/O version just as fast
if not faster as the read() API.
I do have the streaming API working with good performance now. Will get
another patch set up soon.
Thanks,
Eddie
OK, I'll see what I can do.
Thanks for the review!
Eddie
Regards,
Hans
Regards,
Hans
