Em Fri, 07 Sep 2018 14:46:34 +0300
Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> escreveu:
> Hi Mauro,
>
> As maintainers should be held to the same level of obligations as developers,
> and to avoid demotivating reviewers, could you handle comments you receive
> before pushing your own patches to your tree ? There should be no maintainer
> privilege here.
Sorry, yeah, this was improperly handled. Not sure what happened.
>From whatever reason, I ended by mishandling this and lost the
related emails. I had to do several e-mail changes at the beginning
of August, as I'm not using s-opensource.com anymore, and had to
reconfigure my inbox handling logic.
Do you want me to revert the patch?
>
> On Wednesday, 8 August 2018 18:45:49 EEST Laurent Pinchart wrote:
> > Hi Mauro,
> >
> > Thank you for the patch.
> >
> > The subject line should be "media: omap3isp: ...".
> >
> > On Wednesday, 8 August 2018 17:52:55 EEST Mauro Carvalho Chehab wrote:
> > > As sparse complains:
> > > drivers/media/platform/omap3isp/isp.c:303:39: warning: Using plain
> > > integer
> > >
> > > as NULL pointer
> > >
> > > when a struct is initialized with { 0 }, actually the first
> > > element of the struct is initialized with zeros, initializing the
> > > other elements recursively. That can even generate gcc warnings
> > > on nested structs.
> > >
> > > So, instead, use the gcc-specific syntax for that (with is used
> > > broadly inside the Kernel), initializing it with {};
> > >
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx>
> > > ---
> > >
> > > drivers/media/platform/omap3isp/isp.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/media/platform/omap3isp/isp.c
> > > b/drivers/media/platform/omap3isp/isp.c index 03354d513311..842e2235047d
> > > 100644
> > > --- a/drivers/media/platform/omap3isp/isp.c
> > > +++ b/drivers/media/platform/omap3isp/isp.c
> > > @@ -300,7 +300,7 @@ static struct clk *isp_xclk_src_get(struct
> > > of_phandle_args *clkspec, void *data) static int isp_xclk_init(struct
> > > isp_device *isp)
> > >
> > > {
> > >
> > > struct device_node *np = isp->dev->of_node;
> > >
> > > - struct clk_init_data init = { 0 };
> > > + struct clk_init_data init = {};
> >
> > How about = { NULL }; to avoid a gcc-specific syntax ?
> >
> > > unsigned int i;
> > >
> > > for (i = 0; i < ARRAY_SIZE(isp->xclks); ++i)
>
>
Thanks,
Mauro
