Hi Luis, On Fri, Sep 14, 2018 at 7:48 PM, Luis Oliveira <Luis.Oliveira@xxxxxxxxxxxx> wrote: > +++ b/drivers/media/platform/dwc/dw-csi-plat.c > @@ -0,0 +1,508 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later According to Documentation/process/license-rules.rst this should be: // SPDX-License-Identifier: GPL-2.0+ > +static int > +dw_mipi_csi_parse_dt(struct platform_device *pdev, struct mipi_csi_dev *dev) > +{ > + struct device_node *node = pdev->dev.of_node; > + struct v4l2_fwnode_endpoint endpoint; > + int ret = 0; No need to assign ret to 0. > + > + ret = of_property_read_u32(node, "snps,output-type", &dev->hw.output); > --- /dev/null > +++ b/drivers/media/platform/dwc/dw-csi-plat.h > @@ -0,0 +1,76 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ Same as before. > diff --git a/drivers/media/platform/dwc/dw-mipi-csi.c b/drivers/media/platform/dwc/dw-mipi-csi.c > new file mode 100644 > index 0000000..926b287 > --- /dev/null > +++ b/drivers/media/platform/dwc/dw-mipi-csi.c > @@ -0,0 +1,491 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later Ditto. > +void dw_mipi_csi_fill_timings(struct mipi_csi_dev *dev, > + const struct v4l2_bt_timings *bt) > +{ > + No need for this empty line. > + if (bt == NULL) > diff --git a/drivers/media/platform/dwc/dw-mipi-csi.h b/drivers/media/platform/dwc/dw-mipi-csi.h > new file mode 100644 > index 0000000..eca0e48 > --- /dev/null > +++ b/drivers/media/platform/dwc/dw-mipi-csi.h > @@ -0,0 +1,202 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ Ditto.