At PC consumer devices, it is very common that the bridge same driver to be attached to different types of tuners and demods. We need a way for the Kernel to properly identify what kind of signal is provided by each PAD, in order to properly setup the pipelines. The previous approach were to hardcode a fixed number of PADs for all elements of the same type. This is not good, as different devices may actually have a different number of pads. It was acceptable in the past, as there were a promisse of adding "soon" a properties API that would allow to identify the type for each PADs, but this was never merged (or even a patchset got submitted). So, replace this approach by another one: add a "taint" mark to pads that contain different types of signals. I tried to minimize the number of signals, in order to make it simpler to convert from the past way. For now, it is tested only with a simple grabber device. I intend to do more tests before merging it, but it would be interesting to have this merged for Kernel 4.19, as we'll now be exposing the pad index via the MC API version 2. -- v2: - Fix some issues noticed while testing with WinTV USB2. As result of such tests, I opted to use just one type for all analog signals. - Added a patch to provide some info if something gets wrong while creating the links. Mauro Carvalho Chehab (14): media: v4l2: remove VBI output pad media: v4l2: taint pads with the signal types for consumer devices v4l2-mc: switch it to use the new approach to setup pipelines media: v4l2-mc: add print messages when media graph fails media: dvb: use signals to discover pads media: au0828: use signals instead of hardcoding a pad number media: au8522: declare its own pads media: msp3400: declare its own pads media: saa7115: declare its own pads media: tvp5150: declare its own pads media: si2157: declare its own pads media: saa7134: declare its own pads media: mxl111sf: declare its own pads media: v4l2-mc: get rid of global pad indexes drivers/media/dvb-core/dvbdev.c | 19 ++- drivers/media/dvb-frontends/au8522_decoder.c | 10 +- drivers/media/dvb-frontends/au8522_priv.h | 9 +- drivers/media/i2c/msp3400-driver.c | 6 +- drivers/media/i2c/msp3400-driver.h | 8 +- drivers/media/i2c/saa7115.c | 18 ++- drivers/media/i2c/tvp5150.c | 21 ++- drivers/media/media-entity.c | 26 ++++ drivers/media/pci/saa7134/saa7134-core.c | 9 +- drivers/media/pci/saa7134/saa7134.h | 8 +- drivers/media/tuners/si2157.c | 11 +- drivers/media/tuners/si2157_priv.h | 9 +- drivers/media/usb/au0828/au0828-core.c | 12 +- drivers/media/usb/dvb-usb-v2/mxl111sf.c | 8 +- drivers/media/usb/dvb-usb-v2/mxl111sf.h | 8 +- drivers/media/v4l2-core/tuner-core.c | 54 +++++++- drivers/media/v4l2-core/v4l2-mc.c | 135 +++++++++++++++---- include/media/media-entity.h | 48 +++++++ include/media/v4l2-mc.h | 78 ----------- 19 files changed, 347 insertions(+), 150 deletions(-) -- 2.17.1
