Dne 14.9.2018 v 14:59 Sakari Ailus napsal(a): > Hi Petr, > > On Wed, Aug 15, 2018 at 03:30:23PM +0200, petrcvekcz@xxxxxxxxx wrote: >> From: Petr Cvek <petrcvekcz@xxxxxxxxx> >> >> This patch series transfer the ov9640 driver from the soc_camera subsystem >> into a standalone v4l2 driver. There is no changes except the required >> v4l2_async calls, GPIO allocation, deletion of now unused variables, >> a change from mdelay() to msleep() and an addition of SPDX identifiers >> (as suggested in the v1 version RFC). >> >> The config symbol has been changed from CONFIG_SOC_CAMERA_OV9640 to >> CONFIG_VIDEO_OV9640. >> >> Also as the drivers of the soc_camera seems to be orphaned I'm volunteering >> as a maintainer of the driver (I own the hardware). > > Thanks for the set. The patches seem good to me as such but there's some > more work to do there. For one, the depedency to v4l2_clk should be > removed; the common clock framework has supported clocks from random > devices for many, many years now. > > The PXA camera driver does still depend on v4l2_clk so I guess this is > better to do later on in a different patchset. > Yeah I too would like to remove the v4l2_clk from both of them. We've had the discussion about clock dependency around v1 patch set: "[BUG, RFC] media: Wrong module gets acquired" cheers, Petr
