On 09/13/18 15:54, Mauro Carvalho Chehab wrote:
>> switch (ctx->src_fmt.pixelformat) {
>> case V4L2_PIX_FMT_MPEG2_SLICE:
>> - run.mpeg2.slice_params = cedrus_find_control_data(ctx,
>> - V4L2_CID_MPEG_VIDEO_MPEG2_SLICE_PARAMS);
>> - run.mpeg2.quantization = cedrus_find_control_data(ctx,
>> - V4L2_CID_MPEG_VIDEO_MPEG2_QUANTIZATION);
>> + run.mpeg2.slice_params =
>> + cedrus_find_control_data(ctx,
>> + V4L2_CID_MPEG_VIDEO_MPEG2_SLICE_PARAMS);
>> + run.mpeg2.quantization =
>> + cedrus_find_control_data(ctx,
>> + V4L2_CID_MPEG_VIDEO_MPEG2_QUANTIZATION);
>
> Nah, this an example where we should violate the 80-columns limit, in order
> to make easier for humans to understand.
>
> I would code it as:
>
> run.mpeg2.slice_params = cedrus_find_control_data(ctx,
> V4L2_CID_MPEG_VIDEO_MPEG2_SLICE_PARAMS);
Why not keep this unchanged? There is nothing wrong IMHO with
the original:
run.mpeg2.slice_params = cedrus_find_control_data(ctx,
V4L2_CID_MPEG_VIDEO_MPEG2_SLICE_PARAMS);
Perfectly readable, and certainly better then Maxime's or your version.
Regards,
Hans
