Hi Mauro,
On Wednesday, 12 September 2018 16:27:49 EEST Mauro Carvalho Chehab wrote:
> Em Fri, 3 Aug 2018 12:37:30 +0100 Kieran Bingham escreveu:
> > From: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> >
> > Use the newly exposed VSP1 interface to enable interlaced frame support
> > through the VSP1 LIF pipelines.
> >
> > The DSMR register is updated to set the ODEV flag on interlaced
> > pipelines, thus defining an interlaced stream as having the ODD field
> > located in the second half (BOTTOM) of the frame buffer.
> >
> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> Hi Kieran,
>
> It seems that some patches from this series were merged already,
> while others (including this one) weren't.
>
> Could you please generate a v7 of this series with the stuff that
> it is still missing?
>
> I'll mark the remaining v6 patches as Superseded on Patchwork.
This patch should be the only one not merged yet. It will get merged in v4.20
through Dave's tree.
> > ---
> > v5
> >
> > - Fix commit title
> > - Document change to DSMR
> > - Configure through vsp1_du_setup_lif(), rather than
> > vsp1_du_atomic_update()
> >
> > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 1 +
> > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c index 15dc9caa128b..b52b3e817b93
> > 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
> > @@ -289,6 +289,7 @@ static void rcar_du_crtc_set_display_timing(struct
> > rcar_du_crtc *rcrtc)
> > /* Signal polarities */
> > value = ((mode->flags & DRM_MODE_FLAG_PVSYNC) ? DSMR_VSL : 0)
> > | ((mode->flags & DRM_MODE_FLAG_PHSYNC) ? DSMR_HSL : 0)
> > + | ((mode->flags & DRM_MODE_FLAG_INTERLACE) ? DSMR_ODEV : 0)
> > | DSMR_DIPM_DISP | DSMR_CSPM;
> > rcar_du_crtc_write(rcrtc, DSMR, value);
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c index 72eebeda518e..a042f116731b
> > 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> > @@ -52,6 +52,7 @@ void rcar_du_vsp_enable(struct rcar_du_crtc *crtc)
> > struct vsp1_du_lif_config cfg = {
> > .width = mode->hdisplay,
> > .height = mode->vdisplay,
> > + .interlaced = mode->flags & DRM_MODE_FLAG_INTERLACE,
> > .callback = rcar_du_vsp_complete,
> > .callback_data = crtc,
> > };
--
Regards,
Laurent Pinchart
