Re: [PATCH 1/2] vicodec: Drop unneeded symbol dependency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2018-09-10 at 17:23 +0200, Hans Verkuil wrote:
> On 09/10/2018 05:21 PM, Ezequiel Garcia wrote:
> > The vicodec doesn't use the Subdev API, so drop the dependency.
> > 
> > Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx>
> > ---
> >  drivers/media/platform/vicodec/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/platform/vicodec/Kconfig b/drivers/media/platform/vicodec/Kconfig
> > index 2503bcb1529f..ad13329e3461 100644
> > --- a/drivers/media/platform/vicodec/Kconfig
> > +++ b/drivers/media/platform/vicodec/Kconfig
> > @@ -1,6 +1,6 @@
> >  config VIDEO_VICODEC
> >  	tristate "Virtual Codec Driver"
> > -	depends on VIDEO_DEV && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> 
> But it definitely needs the MEDIA_CONTROLLER. That's what it should depend on.
> 

Does it really? The code have proper ifdefs.



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux