On 08/29/2018 12:52 PM, Sakari Ailus wrote: > The sub-device name is set right after in v4l2_i2c_subdev_init(). Remove > the redundant strcpy() call. > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> Thanks! Hans > --- > drivers/media/i2c/sr030pc30.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/i2c/sr030pc30.c b/drivers/media/i2c/sr030pc30.c > index 2a4882cddc51..3d3fb1cda28c 100644 > --- a/drivers/media/i2c/sr030pc30.c > +++ b/drivers/media/i2c/sr030pc30.c > @@ -703,7 +703,6 @@ static int sr030pc30_probe(struct i2c_client *client, > return -ENOMEM; > > sd = &info->sd; > - strcpy(sd->name, MODULE_NAME); > info->pdata = client->dev.platform_data; > > v4l2_i2c_subdev_init(sd, client, &sr030pc30_ops); >