On 8/22/18 3:49 AM, Hans Verkuil wrote: > On 08/22/2018 05:35 AM, Helen Koike wrote: >> Hello, >> >> One of the discussions we had when developing Vimc, was regarding >> optimizing image generation. >> The ideia was to generate the images directly in the capture instead >> of propagating through the pipeline (to make things faster). >> But my question is: if this optimization is on, and if there is a >> greyscaler filter in the middle of the pipeline, do you expect to see >> a grey image with this optimization? > > Yes. > >> Or if we just generate a dummy >> image (with the right size format) at the end of the pipeline, would >> it be ok? (I am asking because it doesn't sound that simple to >> propagate the image transformation made by each entity in the pipe) > > No, that would not be OK. > > My basic idea was that you use a TPG state structure that contains the > desired output: the sensor starts with e.g. 720p using some bayer pixelformat, > the debayer module replaces the pixelformat with e.g. PIX_FMT_RGB32, a > grayscale filter replaces it with PI_FMT_GREY, and that's what the TPG for the > video device eventually will use to generate the video. > > This assumes of course that all the vimc blocks only do operations that can > be handled by the TPG. Depending on what the blocks will do the TPG might need > to be extended if a feature is missing. > > Regards, > > Hans > >> Or do you have any other thing in mind? >> >> Thanks >> Helen >> > Thanks Hans, We'll be working on that soon. Helen
