[PATCH 0/5] Post-v18: Request API updates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Hans Verkuil <hans.verkuil@xxxxxxxxx>

Hi all,

This patch series sits on top of my v18 series for the Request API.
It makes some final (?) changes as discussed in:

https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg134419.html

and:

https://www.spinics.net/lists/linux-media/msg138596.html

The combined v18 patches + this series is available here:

https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=reqv18-1

Updated v4l-utils for this is available here:

https://git.linuxtv.org/hverkuil/v4l-utils.git/log/?h=request

Userspace visible changes:

- Invalid request_fd values now return -EINVAL instead of -ENOENT.
- It is no longer possible to use VIDIOC_G_EXT_CTRLS for requests
  that are not completed. -EACCES is returned in that case.

Driver visible changes (important for the cedrus driver!):

Drivers should set the new vb2_queue 'supports_request' bitfield to 1
if a vb2_queue can support requests. Otherwise the queue cannot be
used with requests.

This bitfield is also used to fill in the new capabilities field
in struct v4l2_requestbuffers and v4l2_create_buffers.

There will be a follow-up documentation patch incorporating
Laurent's comments, but that doesn't change any APIs.

Regards,

	Hans

Hans Verkuil (5):
  media-request: return -EINVAL for invalid request_fds
  v4l2-ctrls: return -EACCES if request wasn't completed
  buffer.rst: only set V4L2_BUF_FLAG_REQUEST_FD for QBUF
  videodev2.h: add new capabilities for buffer types
  vb2: set reqbufs/create_bufs capabilities

 Documentation/media/uapi/v4l/buffer.rst       |  6 ++--
 .../media/uapi/v4l/vidioc-create-bufs.rst     | 10 +++++-
 .../media/uapi/v4l/vidioc-g-ext-ctrls.rst     | 36 +++++++++----------
 Documentation/media/uapi/v4l/vidioc-qbuf.rst  | 12 +++----
 .../media/uapi/v4l/vidioc-reqbufs.rst         | 36 ++++++++++++++++++-
 .../media/common/videobuf2/videobuf2-v4l2.c   | 19 +++++++++-
 drivers/media/media-request.c                 |  6 ++--
 drivers/media/platform/vim2m.c                |  1 +
 drivers/media/platform/vivid/vivid-core.c     |  5 +++
 drivers/media/v4l2-core/v4l2-compat-ioctl32.c |  4 ++-
 drivers/media/v4l2-core/v4l2-ctrls.c          |  5 ++-
 drivers/media/v4l2-core/v4l2-ioctl.c          |  4 +--
 include/media/videobuf2-core.h                |  2 ++
 include/uapi/linux/videodev2.h                | 13 +++++--
 14 files changed, 118 insertions(+), 41 deletions(-)

-- 
2.18.0




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux