Hi Mauro, On Mon, Aug 13, 2018 at 05:50:00PM -0300, Mauro Carvalho Chehab wrote: ... > > > + > > > +/******************* ipu3_uapi_stats_3a *******************/ > > > + > > > +#define IPU3_UAPI_MAX_STRIPES 2 > > > +#define IPU3_UAPI_MAX_BUBBLE_SIZE 10 > > > + > > > +#define IPU3_UAPI_GRID_START_MASK (BIT(12) - 1) > > > +#define IPU3_UAPI_GRID_Y_START_EN BIT(15) > > > + > > > +/* controls generation of meta_data (like FF enable/disable) */ > > > +#define IPU3_UAPI_AWB_RGBS_THR_B_EN BIT(14) > > > +#define IPU3_UAPI_AWB_RGBS_THR_B_INCL_SAT BIT(15) > > > + > > > +/** > > > + * struct ipu3_uapi_grid_config - Grid plane config > > > + * > > > + * @width: Grid horizontal dimensions, in number of grid blocks(cells). > > > + * @height: Grid vertical dimensions, in number of grid cells. > > > + * @block_width_log2: Log2 of the width of each cell in pixels. > > > + * for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7]. > > What are you meaning by [3, 7] here? From some comment you had later, > I guess you're meaning that only 3 or 7 are the valid values. This is a notation for a closed interval. Please see: <URL:https://en.wikipedia.org/wiki/Interval_(mathematics)> > > Yet, you're listing from 2^3 to 2^7, and that's confusing. Perhaps > you want to say, instead, that the valid values are at the 3..7 range? > If so, please use something like "values at the [3..7] range". I'd prefer either 3..7 or [3, 7], but the latter is formal. Whether a range is closed or (partially) open matters less with integers though. -- Kind regards, Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
