Hi Kieran,
Thank you for the patch.
On Wednesday, 8 August 2018 19:55:59 EEST Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>
> The RDACM20 is a GMSL camera supporting 1280x800 resolution images
> developed by IMI based on an Omnivision 10635 sensor and a Maxim MAX9271
> GMSL serializer.
>
> The GMSL link carries power, control (I2C) and video data over a
> single coax cable.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>
> ---
> v2:
> - Fix MAINTAINERS entry
>
> MAINTAINERS | 10 +
> drivers/media/i2c/Kconfig | 11 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/rdacm20-ov10635.h | 953 ++++++++++++++++++++++++++++
> drivers/media/i2c/rdacm20.c | 635 ++++++++++++++++++
> 5 files changed, 1610 insertions(+)
> create mode 100644 drivers/media/i2c/rdacm20-ov10635.h
> create mode 100644 drivers/media/i2c/rdacm20.c
[snip]
> diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c
> new file mode 100644
> index 000000000000..352c54902d1c
> --- /dev/null
> +++ b/drivers/media/i2c/rdacm20.c
> @@ -0,0 +1,635 @@
[snip]
> +MODULE_DESCRIPTION("SoC Camera driver for MAX9286<->MAX9271<->OV10635");
You probably want to fix this. Apart from that, the code looks good to me as a
first driver version, knowing that we will continue development and
refactoring to try and separate the OV10635 and MAX9271 code.
> +MODULE_AUTHOR("Vladimir Barinov");
> +MODULE_LICENSE("GPL");
--
Regards,
Laurent Pinchart
